Adds modules #2070

jaredgalanis · 2017-09-24T13:52:45Z

It might be a good idea to suggest using `assert.expect()` while testing that external action test doubles.

* Improve documentation on loading and error event handling Improve documentation on how handle and use the default behaviour for each action. Addresses emberjs/ember.js#15682 * Add code samples

* Tutorial/Simple-component * Converts Tutorials * Update hbs-helper.md

QUEST | Convert code samples to RFC emberjs#176 imports

Add missing postData property to blog-post component

Recommend users to use `assert.expect()`

Consistent with previous code snippets. Eg: https://puu.sh/xW5xJ.png The same template file being referenced further down: https://puu.sh/xW5zP.png

If the variables name matches with example code snippet. It makes easy to read and understand.

Both loops only count up to `2`; the code comment for the loop using `let` incorrectly described it as behaving differently from `var` and counting up to `3`.

Replace Ember.run.debounce by debounce

* Updates import line * Update autocomplete-component.md * Update autocomplete-component.md * Update autocomplete-component.md

* Adds the shell command in the same way it is used throught the tutorial * Adds lines being removed and adds line add and line remove styling * Adds line that was removed and styles * Adds line that was removed and styles * Adds line styling to acceptance test embed

…branch

…uides into es-primer-modules

…ld to fail.

PoziWorld and others added 30 commits August 13, 2017 12:08

Fix "lets" -> "let" in "to instantiate..., and lets"

4888f22

Recommend users to use assert.expect()

613620e

It might be a good idea to suggest using `assert.expect()` while testing that external action test doubles.

Improve documentation on loading and error event handling (emberjs#2073)

1c4299c

* Improve documentation on loading and error event handling Improve documentation on how handle and use the default behaviour for each action. Addresses emberjs/ember.js#15682 * Add code samples

Delete unused patch file (emberjs#2077)

45b3490

Fixed a spelling mistake in the code (emberjs#2078)

b83855d

Add missing postData property to blog-post component

a60381a

Converts Quick Start

8afcc93

Converts Controllers

a8714e8

Converts Configuring Ember

e4e4788

Converts Application Concerns

65afde8

Converts Object Model

096abd7

Converts Components

2cc07c3

Converts Templates

2de5421

Converts Testing

adbc10e

Converts Routing

bc7c0a5

Add ApplicationInstance to spelling exceptions

c618d8e

Converts Models

d325c91

Converts Tutorial

9f5d402

Converts Configuring Ember

c409ce1

Converts code import for Tutorial (emberjs#2014)

0f58b9c

* Tutorial/Simple-component * Converts Tutorials * Update hbs-helper.md

Converts Models (emberjs#2015)

a8f1836

Inline links

16eda20

added import head file (emberjs#2042)

45242af

Update computed-properties.md

0049f2b

Merge pull request emberjs#2004 from emberjs/new-imports

059d710

QUEST | Convert code samples to RFC emberjs#176 imports

adds variable declarations section of primer

a449547

Merge pull request emberjs#2081 from hybridmuse/patch-3

57947d5

Add missing postData property to blog-post component

small tweak

7389f61

Merge pull request emberjs#2072 from migbar/patch-1

69a6822

Recommend users to use `assert.expect()`

Makes it easier to read/consistent

45613fb

Consistent with previous code snippets. Eg: https://puu.sh/xW5xJ.png The same template file being referenced further down: https://puu.sh/xW5zP.png

NullVoxPopuli and others added 29 commits February 17, 2018 16:04

Update Dockerfile (emberjs#2101)

840071d

Update ember-cli.md

5572f44

Update routes-and-templates.md

bf4e766

updates lines added to rentals route

669e701

removes blank lines

45eee70

Adds output when installing styling

50ede47

Add lines to model

196337c

Update hbs-helper.md

d5d7c25

Update ember-cli.md

76f02e5

If the variables name matches with example code snippet. It makes easy to read and understand.

Fix JS code comment for for loop behavior

a6c01b9

Both loops only count up to `2`; the code comment for the loop using `let` incorrectly described it as behaving differently from `var` and counting up to `3`.

htmlsafe imports and links

4d7677c

changes to htmlSafe

713c257

Update writing-helpers.md

ca50c74

Fix small misstake

480a9c9

Replace Ember.run.debounce by debounce

Updates import line (emberjs#2118)

15d3ed6

* Updates import line * Update autocomplete-component.md * Update autocomplete-component.md * Update autocomplete-component.md

Update screenshot for ember-cli-tutorial-style (emberjs#2123)

598704c

Fixed broken urls to serialize API docs (emberjs#2127)

9bd4f6a

find -> findRecord (emberjs#2128)

b1adf30

templates/writing-helpers: Fix missing ES6 import (emberjs#2130)

09d3941

Update writing-helpers.md (emberjs#2131)

f9ef6b7

Adds modules.

2abf05f

Add export later; clean up.

7f9e0f3

Adds contextualization for ember

6fcd46d

Revisions to modules intro per comments

1ed80eb

Updates examples to include new Modules API syntax

cea77be

Removes sections not currently on master being dealt with in another …

ef32917

…branch

Merge branch 'es-primer-modules' of https://github.com/jaredgalanis/g…

6ece851

…uides into es-primer-modules

Clean up some spelling/grammar. Should fix spelling error causing bui…

08b5139

…ld to fail.

locks merged commit c572513 into emberjs:es-primer Feb 17, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adds modules #2070

Adds modules #2070

jaredgalanis commented Sep 24, 2017 •

edited

Loading

Adds modules #2070

Adds modules #2070

Conversation

jaredgalanis commented Sep 24, 2017 • edited Loading

jaredgalanis commented Sep 24, 2017 •

edited

Loading