fix(lang): correct Ja key casing in connections locale - #2058
Open
49EHyeon42 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
In
src/lang/connections.ts, five keys define their Japanese translationunder a capitalized
Ja:property instead ofja::topicTipsenabledAutoResubdisabledAutoResubenabledAutoResubDescdisabledAutoResubDescformati18n(src/utils/i18n.ts) looks upvalues[key][lang]using thelowercase codes from
supportLang, so these five resolve toundefinedandvue-i18n falls back to English.
Reproduced on MQTTX v1.13.0 with the UI language set to 日本語: in the
subscription dialog (サブスクリプション追加), the auto-resubscribe popover
shows "Auto resubscription is enabled / When enabled, MQTTX will
automatically resubscribe..." in English, while everything around it is
Japanese. Expected: 「自動再購読が有効」 etc.
The casing slip was introduced in 1be2461 together with these keys.
Issue Number
None
What is the new behavior?
The five properties are renamed to lowercase
ja:. The Japanesetranslations (already present in the file, just unreachable) now load, and
the popover and multi-topic tip display in Japanese.
Does this PR introduce a breaking change?
Casing-only change on five lines; no translation content is modified.
Specific Instructions
To verify: switch Settings → Language to 日本語, connect to any broker, open
the subscription dialog via サブスクリプション追加, and hover the info icon
next to the dialog title — the popover title/body should now be Japanese.
Other information
None