Skip to content
This repository was archived by the owner on Aug 7, 2020. It is now read-only.

Conversation

@HackToHell
Copy link
Contributor

  • I have thoroughly tested my contribution.
  • The code changes are reflected in the documentation README.md.

The change adds TINI, an init manager to the docker container, this ensures that when docker stop is called, the signal gets properly propagated to the erlang process, right now only the shell script got the signal and it didn't do anything about it(resulting in a sigkill after a timeout).

With this change the erlang process will get the SIGTERM and properly shutdown.(Needs to be handled inside emqttd)

TINI was used over other init systems because it's extremely small and does the job well. (Docker uses this if you use the --init option).

@spring2maz
Copy link
Contributor

we should merge this! (maybe after a rebase on emqx30)
ping @turtleDeng

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants