Implement --emit-symbol-map locally without calling out wasm-opt #25053
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Still needs a test.. |
kripken
approved these changes
Aug 26, 2025
sbc100
force-pushed
the
emit_symbol_map
branch
from
589d8b8 to
6a3dbdb
Compare
|
test lgtm |
|
Oh, but we still need an escaping test. |
Yes, I mentioned that already in the comment above(and in the PR description) |
sbc100
force-pushed
the
emit_symbol_map
branch
from
6a3dbdb to
7e45f7e
Compare
|
Added testing #25060. Now you can see the fix in action. |
sbc100
force-pushed
the
emit_symbol_map
branch
from
7e45f7e to
2532c4e
Compare
sbc100
added a commit
to WebAssembly/binaryen
that referenced
this pull request
Aug 26, 2025
This is no longer needed by emscripten. See emscripten-core/emscripten#25053.
kripken
approved these changes
Aug 26, 2025
The binaryen version was outputting strange mangled C++ names. Doing this in python should be faster since we don't need to parse the whole binary. Still needs a test. Fixes: emscripten-core#24982
sbc100
force-pushed
the
emit_symbol_map
branch
from
2532c4e to
6ea46cd
Compare
sbc100
added a commit
to WebAssembly/binaryen
that referenced
this pull request
Aug 26, 2025
This is no longer needed by emscripten. See emscripten-core/emscripten#25053.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The binaryen version was outputting strange mangled C++ names.
Doing this in python should be faster since we don't need to parse the whole binary.