Skip to content

Conversation

dschuff
Copy link
Member

@dschuff dschuff commented Oct 9, 2025

By default ccache includes the compiler mtime and ctime in its hash.
But we use the compiler version as the key for the CircleCI cache step,
so different compiler versions will never share a cache. This will prevent
a mismatch across jobs.

@dschuff dschuff marked this pull request as ready for review October 10, 2025 00:59
@dschuff
Copy link
Member Author

dschuff commented Oct 10, 2025

I don't know if this is actually causing the cache problems but it seems like it couldn't hurt.

@dschuff dschuff requested a review from sbc100 October 10, 2025 16:19
Copy link
Collaborator

@sbc100 sbc100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rubberstamp lgtm

@dschuff dschuff merged commit 8751e54 into emscripten-core:main Oct 10, 2025
32 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants