-
-
Notifications
You must be signed in to change notification settings - Fork 7k
Bigint coerce to string #9775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Bigint coerce to string #9775
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -371,6 +371,14 @@ When set to `True`, the serializer `DecimalField` class will return strings inst | |
|
|
||
| Default: `True` | ||
|
|
||
| #### COERCE_BIGINT_TO_STRING | ||
|
|
||
| When returning biginteger objects in API representations that do not support numbers up to 2^64, it is best to return the value as a string. This avoids the loss of precision that occurs with biginteger implementations. | ||
|
|
||
| When set to `True`, the serializer `BigIntegerField` class will return strings instead of `BigInteger` objects. When set to `False`, serializers will return `BigInteger` objects, which the default JSON encoder will return as numbers. | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. add |
||
|
|
||
| Default: `False` | ||
|
|
||
| --- | ||
|
|
||
| ## View names and descriptions | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -30,7 +30,7 @@ | |
| get_referenced_base_fields_from_q, postgres_fields | ||
| ) | ||
| from rest_framework.exceptions import ErrorDetail, ValidationError | ||
| from rest_framework.fields import get_error_detail | ||
| from rest_framework.fields import get_error_detail, BigIntegerField | ||
|
||
| from rest_framework.settings import api_settings | ||
| from rest_framework.utils import html, model_meta, representation | ||
| from rest_framework.utils.field_mapping import ( | ||
|
|
@@ -906,7 +906,8 @@ class ModelSerializer(Serializer): | |
| """ | ||
| serializer_field_mapping = { | ||
| models.AutoField: IntegerField, | ||
| models.BigIntegerField: IntegerField, | ||
| models.BigAutoField: BigIntegerField, | ||
| models.BigIntegerField: BigIntegerField, | ||
| models.BooleanField: BooleanField, | ||
| models.CharField: CharField, | ||
| models.CommaSeparatedIntegerField: CharField, | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1099,6 +1099,68 @@ class TestMinMaxIntegerField(FieldValues): | |
| field = serializers.IntegerField(min_value=1, max_value=3) | ||
|
|
||
|
|
||
| class TestBigIntegerField(FieldValues): | ||
| """ | ||
| Valid and invalid values for `BigIntegerField`. | ||
| """ | ||
| valid_inputs = { | ||
| '1': 1, | ||
| '0': 0, | ||
| 1: 1, | ||
| 0: 0, | ||
| 123: 123, | ||
| -123: -123, | ||
| '999999999999999999999999999': 999999999999999999999999999, | ||
| -999999999999999999999999999: -999999999999999999999999999, | ||
| 1.0: 1, | ||
| 0.0: 0, | ||
| '1.0': 1 | ||
| } | ||
| invalid_inputs = { | ||
| 0.5: ['A valid biginteger is required.'], | ||
| 'abc': ['A valid biginteger is required.'], | ||
| '0.5': ['A valid biginteger is required.'] | ||
| } | ||
| outputs = { | ||
| '1': 1, | ||
| '0': 0, | ||
| 1: 1, | ||
| 0: 0, | ||
| 1.0: 1, | ||
| 0.0: 0, | ||
| '999999999999999999999999999': 999999999999999999999999999, | ||
| -999999999999999999999999999: -999999999999999999999999999 | ||
| } | ||
| field = serializers.BigIntegerField() | ||
|
|
||
|
|
||
| class TestMinMaxBigIntegerField(FieldValues): | ||
| """ | ||
| Valid and invalid values for `IntegerField` with min and max limits. | ||
| """ | ||
| valid_inputs = { | ||
| '1': 1, | ||
| '3': 3, | ||
| 1: 1, | ||
| 3: 3, | ||
| } | ||
| invalid_inputs = { | ||
| 0: ['Ensure this value is greater than or equal to 1.'], | ||
| 4: ['Ensure this value is less than or equal to 3.'], | ||
| '0': ['Ensure this value is greater than or equal to 1.'], | ||
| '4': ['Ensure this value is less than or equal to 3.'], | ||
| } | ||
| outputs = {} | ||
| field = serializers.BigIntegerField(min_value=1, max_value=3) | ||
|
|
||
|
|
||
| class TestCoercionBigIntegerField(TestCase): | ||
|
|
||
| def test_force_coerce_to_string(self): | ||
| field = serializers.BigIntegerField(coerce_to_string=True) | ||
| assert isinstance(field.to_representation(int('1')), str) | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why And why only test the type, not the value itself? |
||
|
|
||
|
|
||
| class TestFloatField(FieldValues): | ||
| """ | ||
| Valid and invalid values for `FloatField`. | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo (
BigInterger)