Skip to content

bug(reload exclude dir): Resolve directory path before comparing to path.parents() #2605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

schloerke
Copy link

Summary

This is just the bug fix from #2602

  • bug: Checking if a excluded path is within a path's .parents() only works if the excluded path is an absolute path.
    • The watched paths (config.reload_dirs) are absolute, so the path parents are also absolute.
    • Therefore, all excluded dirs in FileFilter should also be absolute paths.

Checklist

  • I understand that this PR may be closed in case there was no previous discussion. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • [NA] I've updated the documentation accordingly.

schloerke added a commit to posit-dev/py-shiny that referenced this pull request Mar 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant