Skip to content

comments override and teardown on any comment fixed#216

Merged
hemant-endee merged 1 commit intomasterfrom
omnish/ci_admin_access
Apr 17, 2026
Merged

comments override and teardown on any comment fixed#216
hemant-endee merged 1 commit intomasterfrom
omnish/ci_admin_access

Conversation

@omnish-endee
Copy link
Copy Markdown
Contributor

  • Triggering the benchmarking action multiple times now creates a new comment each time instead of overwriting the existing one, thereby preserving previous results.

  • Previously, two jobs were triggered for any comment; this behavior has been updated so that the jobs now run only for specific comments.

  • Benchmarking actions can now be triggered only by administrators.

@github-actions
Copy link
Copy Markdown

VectorDB Benchmark - Ready To Run

CI Passed ([lint + unit tests] (https://github.com/endee-io/endee/actions/runs/24557888396)) - benchmark options unlocked.

Post one of the command below. Only members with write access can trigger runs.


Available Modes

Mode Command What runs
Dense /correctness_benchmarking dense HNSW insert throughput · query P50/P95/P99 · recall@10 · concurrent QPS
Hybrid /correctness_benchmarking hybrid Dense + sparse BM25 fusion · same suite + fusion latency overhead

Infrastructure

Server Role Instance
Endee Server Endee VectorDB — code from this branch t2.large
Benchmark Server Benchmark runner t3a.large

Both servers start on demand and are always terminated after the run — pass or fail.


How Correctness Benchmarking Works

1. Post /correctness_benchmarking <mode>
2. Endee Server Create  →  this branch's code deployed  →  Endee starts in chosen mode
3. Benchmark Server Create  →  benchmark suite transferred
4. Benchmark Server runs correctness benchmarking against Endee Server
5. Results posted back here  →  pass/fail + full metrics table
6. Both servers terminated   →  always, even on failure

After a new push, CI must pass again before this menu reappears.

@hemant-endee hemant-endee merged commit 9a3f3cc into master Apr 17, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants