Skip to content

Conversation

@Kekun
Copy link
Contributor

@Kekun Kekun commented Oct 15, 2025

This overrides GNOME Initial Setup from gnome-build-meta by https://github.com/Kekun/eos-gnome-initial-setup/tree/eos7.0, a fork of https://github.com/endlessm/gnome-initial-setup that rebases its commits from 43.2 to 48.1.

I still need to build and test this.

This fixes #166.

@Kekun Kekun force-pushed the adrienplazas/gnome-initial-setup branch 2 times, most recently from e5871cd to 4bd30a5 Compare October 16, 2025 08:00
@ssssam ssssam mentioned this pull request Oct 24, 2025
@Kekun Kekun force-pushed the adrienplazas/gnome-initial-setup branch 2 times, most recently from 004e34c to b59839b Compare October 27, 2025 10:33
@Kekun
Copy link
Contributor Author

Kekun commented Oct 27, 2025

The branch where I rebased your gnome-initial-patches on 48.1 compares to your 43.2-based one in the following ways:

  • Upstreamed commits appear earlier in the tree.
  • I dropped all translation updates from Transifex, but kept the commit adding the Transifex configuration.
  • I dropped driver: Avoid unused variable with webkit < 2.39.5 as the guarded code doesn't exist anymore.
  • I suppressed both GOA-related commits as GNOME Online Accounts has been removed from GNOME Initial Setup.
  • I changed the remaining commits so they fit in the new codebase.

@Kekun
Copy link
Contributor Author

Kekun commented Oct 27, 2025

Commit account-local: limit full name to 80 characters may be dropped as its commit message suggests it's related to Debian-based systems. Will suggested testing its relevance by dropping it and testing creating a user with a 256-letters username.

@Kekun Kekun force-pushed the adrienplazas/gnome-initial-setup branch 4 times, most recently from 55506b2 to cb3fba4 Compare October 28, 2025 09:17
@Kekun
Copy link
Contributor Author

Kekun commented Oct 28, 2025

I confirm that:

  • Endless OS 7 uses useradd, and not adduser like endless OS 6.
  • The vanilla GNOME Initial Setup limits full user names to 256 characters (the entry's max0length property is 255).
  • That you can successfully create users with 256 characters full names.
  • That the "account-local: limit full name to 80 characters" patch can be dropped (hence I will drop it now).

@Kekun Kekun force-pushed the adrienplazas/gnome-initial-setup branch 2 times, most recently from 9cb184e to 7a045b8 Compare October 28, 2025 14:06
@Kekun
Copy link
Contributor Author

Kekun commented Oct 28, 2025

I believe this and https://github.com/Kekun/eos-gnome-initial-setup/tree/eos7.0 are ready for review, let me know what you think of them! 🙂

Copy link
Contributor

@starnight starnight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Have a review comment.

I also squashed the fixup commits in @Kekun's gnome-initial-setup eos7.0 branch, then pushed into EOS gnome-initial-setup as branch 166-gnome-initial-setup-48.1. Please update gnome-initial-setup.bst's source, too.

Adrien Plazas added 2 commits October 29, 2025 09:41
This will be needed by GNOME Initial Setup once adding Endless' EULA
page.
@Kekun Kekun force-pushed the adrienplazas/gnome-initial-setup branch from 7a045b8 to e015f79 Compare October 29, 2025 08:47
Copy link
Contributor

@starnight starnight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Only nitpick. After fix, I think it is good to merge, then let it build and test the image.

@Kekun Kekun force-pushed the adrienplazas/gnome-initial-setup branch from e015f79 to cc9151a Compare October 29, 2025 14:06
@Kekun
Copy link
Contributor Author

Kekun commented Oct 30, 2025

Let me know if anything is needed from me to merge this. 🙂

@starnight starnight changed the title WIP: Use the rebased forked GNOME Initial Setup Use the rebased forked GNOME Initial Setup Oct 31, 2025
@starnight starnight merged commit 47009f1 into main Nov 5, 2025
1 check passed
@starnight starnight deleted the adrienplazas/gnome-initial-setup branch November 5, 2025 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rebase gnome-initial-setup patches

3 participants