-
Notifications
You must be signed in to change notification settings - Fork 2
Use the rebased forked GNOME Initial Setup #167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
e5871cd to
4bd30a5
Compare
004e34c to
b59839b
Compare
|
The branch where I rebased your gnome-initial-patches on 48.1 compares to your 43.2-based one in the following ways:
|
|
Commit account-local: limit full name to 80 characters may be dropped as its commit message suggests it's related to Debian-based systems. Will suggested testing its relevance by dropping it and testing creating a user with a 256-letters username. |
55506b2 to
cb3fba4
Compare
|
I confirm that:
|
9cb184e to
7a045b8
Compare
|
I believe this and https://github.com/Kekun/eos-gnome-initial-setup/tree/eos7.0 are ready for review, let me know what you think of them! 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Have a review comment.
I also squashed the fixup commits in @Kekun's gnome-initial-setup eos7.0 branch, then pushed into EOS gnome-initial-setup as branch 166-gnome-initial-setup-48.1. Please update gnome-initial-setup.bst's source, too.
This will be needed by GNOME Initial Setup once adding Endless' EULA page.
7a045b8 to
e015f79
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Only nitpick. After fix, I think it is good to merge, then let it build and test the image.
e015f79 to
cc9151a
Compare
|
Let me know if anything is needed from me to merge this. 🙂 |
This overrides GNOME Initial Setup from gnome-build-meta by https://github.com/Kekun/eos-gnome-initial-setup/tree/eos7.0, a fork of https://github.com/endlessm/gnome-initial-setup that rebases its commits from 43.2 to 48.1.
I still need to build and test this.
This fixes #166.