Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflows: Download and cache Godot Engine for build #21

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

cassidyjames
Copy link
Member

Rather than relying on downloading and executing in a third-party container, we can just grab Godot Engine and the export templates directly from the upstream release page.

We cache these downloads so future runs have the binaries and templates (the latter of which are quite large) available right away for the run.

@cassidyjames cassidyjames requested a review from wjt December 16, 2024 17:26
@cassidyjames cassidyjames marked this pull request as draft December 16, 2024 17:38
@cassidyjames cassidyjames marked this pull request as ready for review December 16, 2024 18:06
@cassidyjames cassidyjames marked this pull request as draft December 16, 2024 18:07
@cassidyjames cassidyjames marked this pull request as ready for review December 16, 2024 18:23
@cassidyjames
Copy link
Member Author

For comparison

Rather than relying on downloading and executing in a third-party container, we can just grab Godot Engine and the export templates directly from the upstream release page.

We cache these downloads so future runs have the binaries and templates (the latter of which are quite large) available right away for the run.
Copy link
Member

@wjt wjt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

It might be nice to wrap this up into a self-contained action – we'll otherwise need to copy this to 2+ other projects – but that could happen later.

@wjt wjt merged commit 2d641a3 into endlessm:main Jan 7, 2025
1 check passed
@cassidyjames cassidyjames deleted the ci-improvements branch January 8, 2025 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants