fix: replace run-with-testrpc with ganache #696
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
run-with-testrpcis not maintained for 4 years already, which is possilbe reason of https://github.com/energywebfoundation/iam-client-lib/actions/runs/5219187364/jobs/9420739666?pr=695As it turned out the real reason of not detecting of network is
localhostin rpc url. It should be127.0.0.1. Not crear why or how this changed.ethersdocumentation provides example of creating JsonRpcProvider withhttp://localhost:8545urlEven if problem was not caused by
run-with-testrpcit still seems usefull to replace itContributor checklist