Skip to content

Conversation

@JGiter
Copy link
Contributor

@JGiter JGiter commented Sep 27, 2022

No description provided.

@JGiter JGiter temporarily deployed to dev September 27, 2022 13:06 Inactive
@JGiter JGiter requested review from jrhender and royki September 27, 2022 13:06
@jrhender
Copy link
Contributor

@JGiter the commit in the PR is strange. It seems to be a merge commit. Is this what you intended?

@jrhender
Copy link
Contributor

@JGiter rather than targeting a different environment in ssi-hub, I think we would be better to hide the prod environment and unhide the production environment in Sentry. In this way, we would keep all of the historical issue data associated with the production environment. So I think we should not merge this PR.
What do you think of this @JGiter @royki ?

@JGiter JGiter force-pushed the task/rename_prod_env branch from 80e7548 to 84293ae Compare September 27, 2022 13:16
@JGiter JGiter temporarily deployed to dev September 27, 2022 13:16 Inactive
@royki
Copy link
Member

royki commented Sep 27, 2022

@JGiter rather than targeting a different environment in ssi-hub, I think we would be better to hide the prod environment and unhide the production environment in Sentry. In this way, we would keep all of the historical issue data associated with the production environment. So I think we should not merge this PR. What do you think of this @JGiter @royki ?

Hi @jrhender will do the the hide prod and unhide production. Don't we need to update SENTRY_ENV value ?
Here is our conversation -

@JGiter
Copy link
Contributor Author

JGiter commented Sep 27, 2022

we would be better to hide the prod environment and unhide the production environment

I would prefer this. @royki Are we updating SENTRY_ENV from prod in ssi-hub, because its corresponds to production in Sentry?

@royki
Copy link
Member

royki commented Sep 27, 2022

we would be better to hide the prod environment and unhide the production environment

I would prefer this. @royki Are we updating SENTRY_ENV from prod in ssi-hub, because its corresponds to production in Sentry?

@JGiter
I'm bit confused. However I'm ok to hide prod and unhide production in Sentry env and check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants