Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump node-fetch from 2.6.6 to 2.6.7 #81

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ViacheslavKudinov
Copy link

@ViacheslavKudinov ViacheslavKudinov commented Feb 11, 2022

Bumps node-fetch from 2.6.6 to 2.6.7.

node-fetch is vulnerable to Exposure of Sensitive Information to an Unauthorized Actor

Severity score 8.8 of 10

GHSA-r683-j2x4-v87g

PS Originally from Dependabot on my fork.
Runs:
https://github.com/vk-or/setup-kind/actions/runs/1828398103
https://github.com/vk-or/setup-kind/actions/runs/1828398100

Bumps [node-fetch](https://github.com/node-fetch/node-fetch) from 2.6.6 to 2.6.7.
- [Release notes](https://github.com/node-fetch/node-fetch/releases)
- [Commits](node-fetch/node-fetch@v2.6.6...v2.6.7)

---
updated-dependencies:
- dependency-name: node-fetch
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@ViacheslavKudinov ViacheslavKudinov marked this pull request as ready for review February 11, 2022 08:59
@ViacheslavKudinov
Copy link
Author

Hi @radu-matei !
Could you, please, review?!

@mmorel-35
Copy link
Contributor

mmorel-35 commented Feb 11, 2022

Hi @ViacheslavKudinov, I already included this fix in #71
I'm saying this to avoid to have to handle a conflict in case this one was merged first

@ViacheslavKudinov
Copy link
Author

ViacheslavKudinov commented Feb 11, 2022

Hi @ViacheslavKudinov, I already included this fix in #71

Aha, I see.
Thanks @mmorel-35 !
I can close mine, but it can be, maybe, more easy to get just this high severity dependency update instead to get more bigger update.

@mmorel-35
Copy link
Contributor

I agree! My developments where already started when this vulnerability happened so I just included it to allow the build to pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants