[DO NOT MERGE] Testing with different engine and skipping or adding todos to failing… #86
Conversation
|
|
||
| } ); | ||
| // TODO do we need this? | ||
| // import { g } from '../docwin'; |
test/spec/axis-native.spec.js
Outdated
| } ); | ||
| } ); | ||
| // TODO I think I missed this initially. Need to revisit all tests. | ||
| // import helpers from '../helpers'; |
There was a problem hiding this comment.
Ok, though they are not currently used, I think axes are a major area for expansion of our spec, especially preceding-sibling I believe browser support them thankfully.
| }; | ||
|
|
||
| expect( test ).to.throw( g.win.XPathException.INVALID_EXPRESSION_ERR ); //,/DOM XPath Exception 51/); | ||
| // TODO Is this good enough? |
|
|
||
| expect( test ).to.throw( g.win.XPathException.NAMESPACE_ERR ); | ||
| // TODO Is this good enough? | ||
| expect( test ).to.throw(); |
| expect( item ).to.not.equal( null ); | ||
| expect( item.nodeType ).to.equal( 13 ); | ||
| //TODO chrome/firefox do not support namespace:node() but we get | ||
| // same result with '.' - Is this node type important? |
There was a problem hiding this comment.
No, not important, I think. Can be commented out.
| } ); | ||
|
|
||
| it( 'returns empty result if the default namespace for the node is empty', () => { | ||
| xit( 'returns empty result if the default namespace for the node is empty', () => { |
There was a problem hiding this comment.
I don't think these 4 commented-out tests are important.
|
|
||
|
|
||
| it( '+ works', () => { | ||
| xit( '+ works', () => { |
There was a problem hiding this comment.
Important, all of the xit tests in this file
| item = result.singleNodeValue; | ||
| expect( item ).to.not.equal( null ); | ||
| expect( item.nodeType ).to.equal( 13 ); | ||
| // TODO chrome/firefox do not support namespace::node but |
There was a problem hiding this comment.
No, I don't think this is important
| it( 'combines different attributes on the same element', () => { | ||
| //TODO Is node order important? chrome vs firefox return different order. | ||
| xit( 'combines different attributes on the same element', () => { | ||
| helpers.checkNodeResult( "id('eee40')/attribute::*[2] | id('eee40')/attribute::*[1]", g.doc, [ |
There was a problem hiding this comment.
That's fine. We can keep this commented out.
|
|
||
| it( 'combines a namespace and attribute', () => { | ||
| //TODO Is node order important? chrome vs firefox return different order. | ||
| xit( 'combines a namespace and attribute', () => { |
There was a problem hiding this comment.
No, not important, I think.
|
@vimemo, I made comments inline. Please let me know if I forgot anything or if you'd like to discuss further. |
2 participants
… tests
Not an actual pull request, but using as a tool to comment inline on the code.
Tests run about 6x faster with the new engine which is a nice improvement :)
I didn't comment on the tests you are already marked with TODO.