Conversation
🛡️ Immunefi PR ReviewsWe noticed that your project isn't set up for automatic code reviews. If you'd like this PR reviewed by the Immunefi team, you can request it manually using the link below: Once submitted, we'll take care of assigning a reviewer and follow up here. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ffe47d13d6
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Co-authored-by: Nick Johnson <arachnid@notdot.net>
Co-authored-by: Nick Johnson <arachnid@notdot.net>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 418a9721c2
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| bytes memory name = NAME_WRAPPER.names(node); | ||
| if (name.length == 0) { | ||
| return false; |
There was a problem hiding this comment.
canModifyName hard-fails when NAME_WRAPPER.names(node) is empty, so ENSv2 names that were never wrapped (for example, names registered directly in ETHRegistrar) can never pass authorization in this resolver. In that case every state-changing profile call (setAddr, setText, etc.) reverts even for the current ENSv2 owner, which makes PublicResolverV2 unusable for those registrations if it is selected as their resolver.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
This resolver is only used by Locked (NameWrapper) names.
2 participants
IAddressSetPermissionedAddressSetand tests — manages a set of addresses with EACPublicResolverV2which is likePublicResolverexceptisAuthorized()uses ENSv2PublicResolverV2.t.solLockedMigrationController.t.solPublicResolverV1in set on devnet