feat: migration of fuses to v2 #17
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 13384803637Details
💛 - Coveralls |
Arachnid
requested changes
Feb 18, 2025
There was a problem hiding this comment.
Can you provide a more detailed design rationale? I'm not really understanding why we need to have registrar-controlled settings (and is this intended to mean settings controlled by a third party designated as the registrar, or settings controlled by the owner of the parent name?
Comment on lines
+25
to
+26
| address public parentRegistry; | ||
| uint256 public parentTokenId; |
There was a problem hiding this comment.
Generally we've avoided introducing these unless absolutely necessary.
| uint256 public parentTokenId; | ||
|
|
||
| // TODO: uint32 for now whilst we iterate on the settings | ||
| mapping(uint256 tokenId => uint32 flags) public settings; |
There was a problem hiding this comment.
Let's call this flags instead of settings.
| // TODO: uint32 for now whilst we iterate on the settings | ||
| mapping(uint256 tokenId => uint32 flags) public settings; | ||
| // Fuse: PARENT_CANNOT_CONTROL - the parent registry will have to lock this subregistry to its parent node + also set this setting here | ||
| uint32 public constant SETTING_REGISTRAR_OWNER_HAS_CONTROL = 0x1; |
There was a problem hiding this comment.
I think this should be 'registry' not 'registrar'.
| // Fuse: CANNOT_RENEW | ||
| uint32 public constant SETTING_OWNER_RENEWALS_LOCKED = 0x8; | ||
| // Fuse: CANNOT_TRANSFER | ||
| uint32 public constant SETTING_OWNER_TRANSFER_LOCKED = 0x16; |
There was a problem hiding this comment.
Suggested change
| uint32 public constant SETTING_OWNER_TRANSFER_LOCKED = 0x16; | |
| uint32 public constant SETTING_OWNER_TRANSFER_LOCKED = 0x10; |
| // Fuse: CANNOT_TRANSFER | ||
| uint32 public constant SETTING_OWNER_TRANSFER_LOCKED = 0x16; | ||
|
|
||
| uint32 public constant SETTINGS_OWNER_MASK = 0x28; // 11100 |
There was a problem hiding this comment.
Suggested change
| uint32 public constant SETTINGS_OWNER_MASK = 0x28; // 11100 | |
| uint32 public constant SETTINGS_OWNER_MASK = 0x1C; // 1 1100 |
| } | ||
|
|
||
| function updateOwnerSettings(uint256 _tokenId, uint32 _settings) public onlyTokenOwner(_tokenId) | ||
| withSettings(_tokenId, SETTING_OWNER_SETTINGS_LOCKED, 0) |
There was a problem hiding this comment.
These can be combined into one check.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes: