[desktop][photos] Parse favorited key from google takeout.#10828
[desktop][photos] Parse favorited key from google takeout.#10828AswinAsok wants to merge 2 commits into
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1e6b7be21c
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| const hiddenCollectionIDs = new Set( | ||
| (await savedHiddenCollections()).map((c) => c.id), |
There was a problem hiding this comment.
When a user imports a Google Takeout folder into a newly created hidden album, createHiddenAlbum returns a remote-only collection and the local saved collections are not refreshed until postUploadAction() runs after this handler, so savedHiddenCollections() does not contain that new hidden collection yet. The files uploaded to that hidden collection therefore pass this filter and get added to the visible Favorites collection, leaking hidden imports; use the upload/target collections' visibility in addition to saved state before calling addToFavoritesCollection.
Useful? React with 👍 / 👎.
1 participant
No description provided.