feat: auto-seed admin + healthcheck fix (from PR #41, security hardened)#42
Merged
garfieldstoun merged 1 commit intomainfrom Mar 25, 2026
Merged
Conversation
Contributor
|
Hey @daedalus-mb, two things to address before this can merge: 1. Lint failure (govet shadow) The inner 2. Merge conflict Steps: git fetch origin
git rebase origin/main
# fix the shadow var
git push --force-with-leaseOnce lint is green and the conflict is resolved, this is good to go. |
Cherry-pick community contribution from venturecrew/appset with security fixes: - Auto-seed admin when MESH_SEED_ADMIN=true and no users exist - SECURITY: never log passwords (only email), default MESH_SEED_ADMIN=false in prod - Fix Docker healthcheck: use GET (-O /dev/null) instead of HEAD (--spider) - Update quickstart.md to mention seed admin option Based on: #41 Co-Authored-By: appset <appset@users.noreply.github.com> Co-Authored-By: Venture Crew <venturecrew@users.noreply.github.com> Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
bc24ddb to
344a766
Compare
garfieldstoun
approved these changes
Mar 25, 2026
Contributor
garfieldstoun
left a comment
There was a problem hiding this comment.
LGTM. govet shadow fixed (seedErr/regErr), password leak removed from logs. CI green. Merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Based on community contribution from @venturecrew / @appset in #41, with security fixes:
MESH_SEED_ADMIN=trueand no users exist in DB. Configurable viaMESH_ADMIN_EMAIL,MESH_ADMIN_PASSWORD,MESH_ADMIN_NAMEenv varswget --spider→wget -O /dev/null(our/healthendpoint returns 405 for HEAD)Security fixes vs original PR #41
log.Printf("...%s / %s", email, pass)MESH_SEED_ADMIN:-true(always seeds)MESH_SEED_ADMIN:-false(opt-in)Admin123Closes #41
Test plan
go build ./cmd/api— compilesMESH_SEED_ADMIN=trueon empty DB — admin createddocker composehealthcheck passes🤖 Generated with Claude Code