Skip to content

Use ss58 for loggings #1413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Use ss58 for loggings #1413

wants to merge 2 commits into from

Conversation

JesseAbram
Copy link
Member

Closes #1271

@ameba23 is this enough you think or should I go through the whole code base and do this?

@JesseAbram JesseAbram requested a review from ameba23 May 1, 2025 17:28
ameba23
ameba23 approved these changes May 2, 2025
View reviewed changes
Copy link
Collaborator

@ameba23 ameba23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ameba23 is this enough you think or should I go through the whole code base and do this?

I don't know how many other places we log account ids - but unless you have checked the whole codebase i would leave the issue open.

@JesseAbram JesseAbram requested a review from ameba23 May 2, 2025 15:01
@JesseAbram JesseAbram changed the title Use ss58 loggings for peers to report Use ss58 for loggings May 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ameba23 ameba23 Awaiting requested review from ameba23

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use SS58 AccountIDs in logs?
2 participants
@JesseAbram @ameba23