Skip to content

Add a conditional replace explanation #336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Add a conditional replace explanation #336

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ac4d38f
Add a conditional replace explanation
viraptor Jun 1, 2020
0cd421b
Keyword typo
viraptor Jun 1, 2020
6b59e0e
Rename Maybe to Conditional
viraptor Jun 1, 2020
33c8dc1
Fix colours
viraptor Jun 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions lib/stack_master/change_set.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,8 +68,11 @@ def id
private

def display_resource_change(io, resource_change)
action_name = if resource_change.replacement == 'True'
action_name = case resource_change.replacement
when 'True'
'Replace'
when 'Conditional'
'Conditional replace'
else
resource_change.action
end
Expand All @@ -86,6 +89,8 @@ def display_resource_change_detail(io, action_name, color, detail)
detail_messages = [target_name]
if action_name == 'Replace'
detail_messages << "#{detail.target.requires_recreation} requires recreation"
elsif action_name == 'Conditional replace'
detail_messages << "#{detail.target.requires_recreation} may require recreation"
end
triggered_by = [detail.change_source, detail.causing_entity].compact.join('.')
if detail.evaluation != 'Static'
Expand All @@ -101,7 +106,7 @@ def action_color(action_name)
:green
when 'Modify'
:yellow
when 'Remove', 'Replace'
when 'Remove', 'Replace', 'Maybe replace'
Copy link
Contributor

@stevehodgkiss stevehodgkiss Jun 2, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need to be Conditional replace?

:red
end
end
Expand Down