Conversation
|
CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to |
|
cc @mpwarres @martijneken updating these deps is still blocked by proxy-wasm-cpp-host needing an update (and conversion to crate_universe etc) |
|
/wait @phlax is it still blocked? |
yeah, i believe so |
proxy_wasm_rust_sdk -> 0.2.2proxy_wasm_rust_sdk -> 0.2.2
|
Hi. I'm working on the crate_universe issue, I think that's close to being fixed. @mpwarres is back from OOO this week and will be looking at the macOS issue. Can you clarify which parts are blocking the rust SDK, and whether these CI issues will actually unblock you? I don't know how they are related. |
|
so this is the error ERROR: /build/bazel_root/base/external/proxy_wasm_cpp_host/bazel/cargo/wasmtime/BUILD.bazel:42:6: error loading package '@wasmtime__wasmtime__9_0_3//': cannot load '@rules_rust//cargo:cargo_build_script.bzl': no such file and referenced by '@proxy_wasm_cpp_host//bazel/cargo/wasmtime:wasmtime'
ERROR: Evaluation of query "deps((//contrib/exe/... union //distribution/... union //source/exe/... union @com_github_google_quiche//:ci_tests union @nodejs//... union //test/...))" failed: preloading transitive closure failed: error loading package '@wasmtime__wasmtime__9_0_3//': cannot load '@rules_rust//cargo:cargo_build_script.bzl': no such file
Fetch failedi went down the rabbit hole a little last week and came to the conclusion that we needed to update rules_rust to update proxy_wasm_rust_sdk - i tried to do that here (in this PR) and hit above issue i looked at the changes in the rules_rust repo and (cant rem exactly why) came to the conclusion we need to update cpp-host first |
Ahh gotcha, I'll look at that in CppHost too then. |
|
CppHost CI is fixed, rules_rust to be updated in proxy-wasm/proxy-wasm-cpp-host#406. |
|
brilliant, thanks @martijneken - ill have a go again at bumping this batch of deps |
3cc00ba to
f7a6949
Compare
|
@martijneken thanks - confirming that cpp_host has now been updated unfortunately this still fails due to bazelbuild/rules_rust#2665 |
Seems like we ran into this on the ProxyWasmCppHost side too, and decided to use rules_rust 0.42 for now: Can we do the same here? |
most likely, ill try it now ... |
Signed-off-by: dependency-envoy[bot] <148525496+dependency-envoy[bot]@users.noreply.github.com> Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: dependency-envoy[bot] <148525496+dependency-envoy[bot]@users.noreply.github.com> Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Ryan Northey <ryan@synca.io>
90c4e42 to
818d045
Compare
|
seems not out of the box - afaict its failing due to: which i think is most likely related to the rules_rust version which is higher in rust-sdk |
Hi @phlax and @martijneken , just a drive-by comment. I was working on a personal project and was able to update rules_rust in envoy to the latest version that has Patching rules_rust also worked, but just setting incompatible_merge_fixed_and_default_shell_env to the value that became default in later bazel versions seemed like a better approach. Maybe you can give that a try? |
|
brilliant! huge thanks @krinkinmu - ill give it a whirl |
0b95468 to
fc24e00
Compare
proxy_wasm_rust_sdk -> 0.2.2proxy_wasm_rust_sdk -> 0.2.2
phlax
left a comment
There was a problem hiding this comment.
great, looks like this is finally passing
thanks all!
Created by Envoy dependency bot for @phlax
Fix #35321
also update
rules_rust-> 0.48.0Fix #35291
Signed-off-by: dependency-envoy[bot] <148525496+dependency-envoy[bot]@users.noreply.github.com>