stream: guard delta subscriptions against nil returned resource maps#1488
Open
immanuwell wants to merge 1 commit into
Open
stream: guard delta subscriptions against nil returned resource maps#1488immanuwell wants to merge 1 commit into
immanuwell wants to merge 1 commit into
Conversation
…maps Signed-off-by: immanuwell <pchpr.00@list.ru>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Small bug fix in delta subscription state.
SetReturnedResources(nil)leavesreturnedResourcesnil. If the subscription is wildcard and later unsubscribes a named resource,UpdateResourceSubscriptionswrites into that map and panics withassignment to entry in nil map.This patch normalizes
nilto an empty map, so that path stays safe. Pretty small footgun, easy fix.#
N/A
Type of change
How has this been tested?
Repro before fix:
Before this patch, that panics. After it, no panic and
resourceis tracked as removed, as expected.go test ./...go test -race ./pkg/server/stream/v3 ./pkg/cache/v3 ./pkg/server/v3Test Configuration:
go1.25.0Checklist: