Skip to content

--stats-sinks aborts at startup: no stats sink implementation is registered #1607

Description

@bpalermo

Title: --stats-sinks aborts at startup: no stats sink implementation is registered

Description:
The README documents --stats-sinks with a statsd example, and the flush worker / NighthawkStatsSinkFactory plumbing exists, but no factory implementation is linked into the binaries (the only one is a test fake). Any --stats-sinks value therefore aborts at startup. Expected: the documented statsd config works, pushing counters and Nighthawk's latency histograms to a statsd/DogStatsD receiver so a run can be observed live.

Reproduction steps:

nighthawk_client --stats-sinks '{name:"envoy.stat_sinks.statsd",typed_config:{"@type":"type.googleapis.com/envoy.config.metrics.v3.StatsdSink",address:{socket_address:{address:"127.0.0.1",port_value:8125}}}}' http://127.0.0.1:8080/

Logs:

[I] loading stats sink configuration in Nighthawk
[E] Fatal EnvoyException exception: Didn't find a registered implementation for 'envoy.stat_sinks.statsd' with type URL: 'envoy.config.metrics.v3.StatsdSink'
libc++abi: terminating due to uncaught exception of type Envoy::EnvoyException

Call Stack:
Uncaught exception at startup (ProcessImpl::setupStatsSinks -> Envoy::Config::Utility::getAndCheckFactory), no memory fault.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions