Updates to fits_equinox_update branch
#39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…overall bandwidth.
infinitron
reviewed
Oct 19, 2022
|
|
||
| do_truncate = True | ||
| act_chan_bw = CHAN_BW | ||
| if nchan % self.nchan_out == 0: |
Contributor
There was a problem hiding this comment.
A small suggestion--I think it'd be good if we add an additional check for nchan_out>6 here to avoid integer overflow during averaging. It's highly unlikely that we'll use less than 7 channels to cover the entire subband, but just in case.
Author
There was a problem hiding this comment.
What happens when nchan_out<7?
Contributor
There was a problem hiding this comment.
If we set nchan_out to 4, for example, we average 33 channels and their sum can be greater than 127. This leads to an overflow in the re or im variables in the averaging function that is launched on the gpu.
… cable gains are taken into account.
Slew of updates from my work on the EPIC imaging comparisons.
small typo on import
Fits equinox update jdd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes a few changes to the
fits_equinox_updatebranch. They are:DecimationOpblock that will allow channels to be average together, and