Conversation
Co-authored-by: me <me@kentcdodds.com>
Co-authored-by: me <me@kentcdodds.com>
Co-authored-by: me <me@kentcdodds.com>
Co-authored-by: me <me@kentcdodds.com>
Co-authored-by: me <me@kentcdodds.com>
Co-authored-by: me <me@kentcdodds.com>
Co-authored-by: me <me@kentcdodds.com>
Co-authored-by: me <me@kentcdodds.com>
Co-authored-by: me <me@kentcdodds.com>
Co-authored-by: me <me@kentcdodds.com>
|
Cursor Agent can help with this pull request. Just |
|
@kettanaito feel free to close this if it's not helpful. My prompt was:
It did a lot more work than I expected, but upgrading to vitest 4 apparently required a bit more work than I expected. |
|
Problem is I think some of these changes would require video changes. Either that or you could add callouts in some key places to explain differences in the videos until you get around to updating them. |
exercises/01.sunsetting-jsdom/01.problem.break-jsdom/package.json
Outdated
Show resolved
Hide resolved
|
Bugbot Autofix resolved the bug found in the latest run.
|
|
@kentcdodds, shouldn't we leave the dependencies frozen though? As you pointed out, some updates will have to be reflected in the videos, for which I don't have the time at the moment. I don't see workshops are guidebooks on particular tools. For example, whether we're using Vitest 3.0 or 4.0 is irrelevant to the topic of the workshop, that being in-browser component testing. #9 I had was meant only for the Extras, not for the entire workshop. I have a designated extra materials that walk the students through 3.0 -> 4.0 migration without invalidating anything they've learned prior to that. I'm going to close this! |
|
Fixed it in #11. |
|
Ah perfect 👍👍 Love seeing you use that feature already! |
Update Vitest to v4.0 and remove manual matcher type imports.
Vitest v4.0 automatically includes browser matcher types via
@vitest/browser/context, making explicit imports like@vitest/browser/matchersunnecessary. This PR updates Vitest and related browser dependencies to v4.0.17 and adjusts the TypeScript configuration andvite.config.tsfiles accordingly.Note
Upgrade and config migration
vitestand@vitest/browserto^4.0.17across exercises; adds@vitest/browser-playwright; updates root to includevitestviteconfig refs to/// <reference types="vitest/config" />and configures Playwright viaimport { playwright } from '@vitest/browser-playwright'withprovider: playwright()"types": ["vitest/globals", "@vitest/browser/context"]intsconfig.*.jsonDocs and examples
import.meta.env.DEV, setup file guidance) to align with new browser mode setupWritten by Cursor Bugbot for commit ea9e836. This will update automatically on new commits. Configure here.