Skip to content
This repository was archived by the owner on Aug 25, 2025. It is now read-only.

Conversation

DeepRed
Copy link
Collaborator

@DeepRed DeepRed commented Mar 14, 2025

If the token is invalid and the user cannot be authorized then swallong the unauthorized exception will lead to a null reference error. By exposing the HttpRequestException the application will know that the user was unauthorized.

Fixes: CMS-40534

If the token is invalid and the user cannot be authorized
then swallong the unauthorized exception will lead to
a null reference error. By exposing the HttpRequestException
the application will know that the user was unauthorized.

Fixes: CMS-40534
Copy link

Great job @DeepRed! Your CI passed, and the PR has been automatically labelled.

Once ready, we will merge this PR to trigger the next part of the automation 🚀

@ManhOptimizely
Copy link
Collaborator

Merged to develop.
@DeepRed In case of urgent I can create new release 1.4.1 for fixing this bug.

@DeepRed
Copy link
Collaborator Author

DeepRed commented Mar 17, 2025

@ManhOptimizely its not urgent, just an error I found while helping on a support case. But we need a second approved to merge this. I added Ted, anyone else I should add?

@DeepRed DeepRed requested a review from JoshuaFolkerts March 18, 2025 05:17
@ManhOptimizely ManhOptimizely requested a review from vinhch March 21, 2025 03:24
@ManhOptimizely ManhOptimizely merged commit cc19e87 into main Mar 25, 2025
14 checks passed
@ManhOptimizely ManhOptimizely deleted the bugfix/CMS-40534-unauthorized branch April 10, 2025 06:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants