This repository was archived by the owner on Aug 25, 2025. It is now read-only.
Make OptiGraphOptions to be scoped lifecircle #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OptiGraphOptions is resolved as singleton instance, in some case, developer needs to use different OptiGraphOptions instances for connecting different servers so they would update OptiGraphOptions in runtime. Since it's singleton, it could be updated by other thread/scope and make incorrect requests. This fix change the constructor of GraphQueryBuilder from IOptions<OptiGraphOptions> (singleton) to IOptionsSnapshot<OptiGraphOptions> (scoped snapshot) for supporting developer update OptiGraphOptions in their scope request.
ManhOptimizely
force-pushed
the
bugfix/Make-OptiGraphOptions-to-be-thread-safe
branch
from
ea50a56 to
2a6a1e9
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OptiGraphOptions is resolved as singleton instance, in some case, developer needs to use different OptiGraphOptions instances for connecting different servers so they would update OptiGraphOptions in runtime. Since it's singleton, it could be updated by other thread/scope and make incorrect requests. This fix change the constructor of GraphQueryBuilder from IOptions (singleton) to IOptionsSnapshot (scoped snapshot) for supporting developer update OptiGraphOptions in their scope request.