Fix include-component-in-tag for eds-core-react-next releases #4274
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: torleifhalseth <[email protected]>
Copilot
AI
changed the title
[WIP] Address feedback on configuration effects in /next subpath
Fix include-component-in-tag for eds-core-react-next releases
Nov 27, 2025
Collaborator
|
We dont want to include the component tag so having it as false makes sense in our context. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses review feedback on #4251 asking about the effect of
include-component-in-tag: false.Changes
include-component-in-tagfromfalsetotruefor theeds-core-react-nextcomponentEffect
With
false: tags would be bare versions like0.1.0-beta.0With
true: tags will be[email protected]The
truesetting follows the existing repository convention where all tags include the component prefix (e.g.,[email protected]) and avoids potential tag conflicts in the monorepo.💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.