Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Nov 27, 2025

Addresses review feedback on #4251 regarding duplicated rollup configuration between stable and next builds.

Changes

  • Extract shared external and watch constants
  • Add getPlugins(additionalPlugins) helper for plugin configuration
  • Add getOutput(cjsFile) helper for output configuration

Before/After

// Before: ~97 lines with full duplication
export default [
  { input: ['./src/index.ts'], external: [...], watch: {...}, plugins: [...], output: [...] },
  { input: ['./src/index.next.ts'], external: [...], watch: {...}, plugins: [...], output: [...] },
]

// After: ~74 lines with shared config
export default [
  { input: ['./src/index.ts'], external, watch, plugins: getPlugins([del(...)]), output: getOutput('./dist/eds-core-react.cjs') },
  { input: ['./src/index.next.ts'], external, watch, plugins: getPlugins(), output: getOutput('./dist/index.next.cjs') },
]

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI changed the title [WIP] Fix feedback on configuration duplication in /next subpath refactor: extract shared rollup configuration to reduce duplication Nov 27, 2025
Copilot finished work on behalf of torleifhalseth November 27, 2025 12:07
Copilot AI requested a review from torleifhalseth November 27, 2025 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants