fix: update autocomplete types to require optionLabel when using objects and optional for strings/numbers

[FredrikMWold]

This pull request fixes an issue with the type definition for the optionLabel prop in the Autocomplete component.

Currently, optionLabel is not marked as required, even when the user provides an array of objects as the options. In those cases, the component throws a runtime error if optionLabel is missing.

This PR updates the typing so that optionLabel becomes required whenever the user supplies an array of objects (anything other than string[] or number[]).

[Copilot]

Pull request overview

This PR improves type safety for the Autocomplete component by making the optionLabel prop conditionally required based on the option type. When options are objects (anything other than string or number), optionLabel is now required, which aligns with the runtime behavior that throws an error when it's missing. For string or number options, optionLabel remains optional since these primitives can be displayed directly.

Key changes:

• Modified AutocompleteProps type to use a conditional type that requires optionLabel for object types
• Simplified IndexFinderType to use inline types instead of referencing AutocompleteProps

[Copilot]

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.

[Copilot]

The third branch of the conditional type (lines 345-348) appears to be unreachable. In TypeScript, a type T will either extend string | number or object. Types like boolean, undefined, null, symbol, or bigint that don't fit either category are unlikely to be valid option types for an autocomplete component.

Consider simplifying the conditional type to only two branches and removing the unreachable else clause:

} & HTMLAttributes<HTMLDivElement> &
  (T extends string | number
    ? {
        /**  Custom option label. NOTE: This is optional for primitive types */
        optionLabel?: (option: T) => string
      }
    : {
        /**  Custom option label. NOTE: This is required when option is an object */
        optionLabel: (option: T) => string
      })

This makes the type definition clearer and removes the dead code path.

Suggested change

	/** Custom option label. NOTE: This is required when option is an object */
	optionLabel?: (option: T) => string
	}
	: T extends object
	? {
	/** Custom option label. NOTE: This is required when option is an object */
	optionLabel: (option: T) => string
	}
	: {
	/** Custom option label. NOTE: This is required when option is an object */
	optionLabel?: (option: T) => string
	})
	/** Custom option label. NOTE: This is optional for primitive types */
	optionLabel?: (option: T) => string
	}
	: {
	/** Custom option label. NOTE: This is required when option is an object */
	optionLabel: (option: T) => string
	})

[FredrikMWold]

It might look like its not need but removing breaks the types when somebody tries to wrap it using the styled from styled components

[Copilot]

The documentation comments for optionLabel in all three branches are identical: "Custom option label. NOTE: This is required when option is an object". This is misleading because in the first branch (lines 336-339), optionLabel is actually optional for string | number types.

The comment on line 337 should be updated to reflect that it's optional for primitive types:

/**  Custom option label. NOTE: This is optional for string and number types */
optionLabel?: (option: T) => string

Suggested change

	/** Custom option label. NOTE: This is required when option is an object */
	/** Custom option label. NOTE: This is optional for string and number types */

[pomfrida]

Sublime, thank you ✨