Skip to content

Add support for summary files beyond year 2262#238

Merged
berland merged 2 commits into
masterfrom
year2262
Dec 9, 2023
Merged

Add support for summary files beyond year 2262#238
berland merged 2 commits into
masterfrom
year2262

Conversation

@berland
Copy link
Copy Markdown
Collaborator

@berland berland commented Dec 7, 2023

Copied fallback code from res2df. Since #182 is stale, we duplicate the code from there.

Solves equinor/semeio#474

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Dec 7, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (392218d) 83.31% compared to head (f406f34) 83.49%.

❗ Current head f406f34 differs from pull request most recent head 7230f4e. Consider uploading reports for the commit 7230f4e to get more accurate results

Files Patch % Lines
src/fmu/ensemble/util/dates.py 96.07% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #238      +/-   ##
==========================================
+ Coverage   83.31%   83.49%   +0.17%     
==========================================
  Files          14       14              
  Lines        3026     3071      +45     
==========================================
+ Hits         2521     2564      +43     
- Misses        505      507       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment thread tests/test_realization.py
Copied fallback code from res2df
Copy link
Copy Markdown
Member

@kwinkunks kwinkunks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great.

@berland berland merged commit 364ceb3 into master Dec 9, 2023
@berland berland deleted the year2262 branch December 9, 2023 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants