feat: adds abilty to create build pipeline job #102
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FredrikMWold
force-pushed
the
feat/add_build_pipeline
branch
2 times, most recently
from
5c134e9
to
1d2024b
Compare
|
bump |
satr
requested changes
Aug 26, 2024
Comment on lines
+37
to
+40
| if appName == nil || *appName == "" { | ||
| return errors.New("application name is required") | ||
| } |
There was a problem hiding this comment.
Suggested change
| if appName == nil || *appName == "" { | |
| return errors.New("application name is required") | |
| } | |
| if appName == nil || *appName == "" || branch == "" { | |
| return errors.New("application name and branch are required") | |
| } |
There was a problem hiding this comment.
Or add following
if err := createBuildPipelineJobCmd.MarkFlagRequired(flagnames.Application); err != nil {
log.Fatalf("Error during command initialization: %v", err)
}
instead of
if appName == nil || *appName == "" {
return errors.New("application name is required")
}
to be consistent
| } | ||
|
|
||
| jobName := newJob.GetPayload().Name | ||
| log.SetOutput(cmd.OutOrStdout()) |
There was a problem hiding this comment.
Suggested change
| log.SetOutput(cmd.OutOrStdout()) |
There was a problem hiding this comment.
Log output has to be uniformal with other commands
There was a problem hiding this comment.
Radix CLI prints to stdout only objects , e.g.
radix-cli/cmd/validateRadixConfig.go
Line 180 in 723000d
messages it prints to stderr
There was a problem hiding this comment.
These requested changes are to keep the product and its code consistent. The PR unfortunately cannot be approved without these changes.
FredrikMWold
force-pushed
the
feat/add_build_pipeline
branch
2 times, most recently
from
53e0950
to
af7d5e0
Compare
FredrikMWold
force-pushed
the
feat/add_build_pipeline
branch
from
af7d5e0
to
df4b77d
Compare
FredrikMWold
force-pushed
the
feat/add_build_pipeline
branch
from
df4b77d
to
e3739f8
Compare
|
This code is used (with applied requested changes) to this version](https://github.com/equinor/radix-cli/releases/tag/v1.23.0) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds the
buildcommand tocreate pipeline-job.The logic/plumbing to create a build pipeline was already present. I just added the cobra command itself.