Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Parameters for Firestore Hooks Positional #73

Merged
merged 8 commits into from
Feb 10, 2024

Conversation

erayerdin
Copy link
Owner

No description provided.

@erayerdin erayerdin added type|bug Something isn't working type|docs Improvements or additions to documentation labels Feb 10, 2024
@erayerdin erayerdin self-assigned this Feb 10, 2024
Copy link

codecov bot commented Feb 10, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (d17e041) 84.70% compared to head (618eeb0) 85.27%.

Files Patch % Lines
src/firestore/useCollection.ts 91.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev      #73      +/-   ##
==========================================
+ Coverage   84.70%   85.27%   +0.56%     
==========================================
  Files          39       39              
  Lines        1576     1562      -14     
  Branches      119      121       +2     
==========================================
- Hits         1335     1332       -3     
+ Misses        238      227      -11     
  Partials        3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@erayerdin erayerdin merged commit 4d5e507 into dev Feb 10, 2024
6 checks passed
@erayerdin erayerdin deleted the fix/firestore-hooks-parameters branch February 10, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type|bug Something isn't working type|docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant