Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add positional parameters to Storage hooks #81

Merged
merged 15 commits into from
Feb 18, 2024
Merged

Add positional parameters to Storage hooks #81

merged 15 commits into from
Feb 18, 2024

Conversation

erayerdin
Copy link
Owner

No description provided.

@erayerdin erayerdin added type|bug Something isn't working type|docs Improvements or additions to documentation labels Feb 18, 2024
@erayerdin erayerdin self-assigned this Feb 18, 2024
Copy link

codecov bot commented Feb 18, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (e1c5821) 76.71% compared to head (2405399) 76.27%.

Files Patch % Lines
src/storage/StorageDownloadLink.tsx 0.00% 1 Missing ⚠️
src/storage/StorageMetadata.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev      #81      +/-   ##
==========================================
- Coverage   76.71%   76.27%   -0.45%     
==========================================
  Files          46       46              
  Lines        1722     1690      -32     
  Branches      128      128              
==========================================
- Hits         1321     1289      -32     
  Misses        391      391              
  Partials       10       10              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@erayerdin erayerdin merged commit 297399d into dev Feb 18, 2024
4 of 5 checks passed
@erayerdin erayerdin deleted the fix/parameters branch February 18, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type|bug Something isn't working type|docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant