Skip to content

Conversation

@xhqiao89
Copy link

@snowman2
Copy link
Member

I am happy to see you contributing to RAPIDpy! A couple of things I would like to see before merging this in would be:

  1. Tests demonstrating that your additions work and to ensure stability moving forward.
  2. Your commit history squashed into logical groupings.

Thanks and please ask questions if you have any.

@snowman2
Copy link
Member

Also, adding to the documentation about the models supported.

@xhqiao89
Copy link
Author

@snowman2 This great project has benefited our research for years and we are glad to contribute to it. The preliminary PR is our first step on this right path. We will be updating the it to meet code standards and updating doc over the next few weeks. Thanks.

@snowman2
Copy link
Member

Sounds good 👍

@snowman2
Copy link
Member

snowman2 commented May 6, 2019

I updated my author information in the commit history and it seems to have impacted this PR. You will need to rebase your branch to this repos master branch. A simpler approach may be to create a new branch from this repos master branch and cherry pick your changes into the new branch. Feel free to reach out if you have any questions. Thanks!

@xhqiao89
Copy link
Author

xhqiao89 commented May 6, 2019

@snowman2 Thanks for the information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants