-
Notifications
You must be signed in to change notification settings - Fork 11
Aquaveo leprovost adcirc #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
aclark-aquaveo
wants to merge
31
commits into
erdc:master
Choose a base branch
from
aclark-aquaveo:aquaveo-leprovost-adcirc
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Aquaveo leprovost adcirc #8
aclark-aquaveo
wants to merge
31
commits into
erdc:master
from
aclark-aquaveo:aquaveo-leprovost-adcirc
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…po. Changed the new extractors to return pandas DataFrames. Changed new extractors to download databases from aqauveo.com if not found.
…eo-leprovost-adcirc
…cations for LeProvost and ADCIRC. Changed resource fetching for ADCIRC and LeProvost to check current directory as well as specified. Changed LeProvost and ADCIRC to use fluent interface pattern with get_components to be consistent with TPX0 interface.
add getting started guide
fix docstring and missing import
…uto doc generation. Added a tutorial for using the Python API with TPXO, ADCIRC, and LeProvost.
Contributor
|
@aclark-aquaveo This is a great start at incorporating the LeProvost and ADCIRC databases. My worries are:
|
…class - This an intermediate commit, not ready
removed redundant have_constituent code, fixed doc strings, deleted u…
…4 FES files. Use ResourceManager to load LeProvost NetCDF datasets. Changed LeProvost code to only load the values it needs from file instead of entire dataset. ADCIRC will get these TPXO unifications after its executables are converted. Sorted test script output for compare. LeProvost interface will be broken with this commit until the new NetCDF file is hosted.
…o harmonica interface made it unnecessary.
… will keep the legacy constituents that we distribute all in one file. Made the format of our legacy NetCDF file more compatible with the newer format.
…Currently is bypassing certificate verification until the link works properly.
Aquaveo leprovost adcirc
to a netcdf file for the source of the tidal data. Also, removed a print statement from the LeProvost tidal database extractor.
out code and code used for debugging.
Update LeProvost resource URL
…r can switch models with ease. Moved TPXO implementation from tidal_database.py to tpxo_database.py. Fixed resource fetching for the new ADCIRC NetCDF file.
…IRC implementations to a single function. Return NaN for locations outside the domain. Added a version number (2015) for the current version of the ADCIRC database.
…tituent object as opposed to a single DataFrame. Once this becomes the outer dimension of an xarray, this will probably need to change again.
…s as a result. Changed interface to take datetime object instead of year, month, etc. Updated tutorial.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the initial merge of ADCIRC and LeProvost tidal database extractors. Changed our code to fetch resources from aquaveo.com if not found. Converted our code to return pandas.DataFrames in same format as the TPXO interface. We probably still want to do another pass to make the interfaces more consistent. Added a test case and tutorial for using the Python API with TPXO, ADCIRC, and LeProvost. Added Sphinx files for auto generation of docs.