Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parse non-true values for disabled properties #143

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Parse non-true values for disabled properties #143

wants to merge 1 commit into from

Conversation

ErichDonGubler
Copy link
Collaborator

TODO: figure out design, make things compile

@ErichDonGubler
WIP
6cc135a 
TODO: figure out design, make things compile
@ErichDonGubler ErichDonGubler changed the title WIP Parse non-true values for disabled properties Aug 1, 2024
@ErichDonGubler ErichDonGubler mentioned this pull request Aug 1, 2024
Draft
@sagudev
Copy link
Collaborator

sagudev commented Aug 2, 2024

For design I suggest having Option or option like enum, where Some(String) represents that it is disabled, while None represents that test is enabled (@False is mapped here, but when fmt/write the filed disabled should be removed completely).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ErichDonGubler @sagudev