Remove touchmap serialization #18701
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonis19
requested review from
Giulio2002,
domiwei,
mh0lt and
yperbasis
as code owners
Member
|
started on any node? how was the merges? |
Member
Author
|
Running successfully a node on hoodi. I generated new snapshots from scratch without touchmap using --no-downloader. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#18667
This PR removes the touchmap field from the branchdata serialization format. This simplifies the code and saves 2 bytes per branch serialization.
Using this git branch I was able to successfully sync hoodi from scratch (using
--no-downloader, and with commitment history enabled) which produced state snapshots with a new version of commitment snapshots (where touchmap is not serialized).Space savings (as of recent block 2043962 )
The space savings for domain and history snapshots are modest, but given that the code gets simplified, it might be worth considering for a future version of snapshots (potentially with other schema changes).