fix: avoid duplicate counter creation for gossip topics #18749
+2
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously ObserveGossipTopicSeen called GetOrCreateCounter twice for every new gossip topic and performed an extra Store into gossipMetricsMap. This added unnecessary work and potential allocations on first use of each topic without changing the behavior of the metrics.
This change simplifies ObserveGossipTopicSeen to rely solely on the value returned by sync.Map.LoadOrStore, removing the redundant second GetOrCreateCounter call and duplicate Store. The semantics of the metric and its caching remain the same while eliminating the extra overhead on metric initialization.