Skip to content

Hist.Collate: disable compression to speedup Collate+Build #18752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
AskAlexSharov wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −4
Draft

Hist.Collate: disable compression to speedup Collate+Build #18752

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions db/state/history.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -534,7 +534,7 @@ func (h *History) collate(ctx context.Context, step kv.Step, txFrom, txTo uint64
if h.noFsync {
_histComp.DisableFsync()
}
historyWriter := h.dataWriter(_histComp)
historyWriter := h.dataWriter(_histComp, true) // `Collate+Build` must be fast -> no Compression. Slowness here means growth of `chaindata`

_efComp, err = seg.NewCompressor(ctx, "collate idx "+h.FilenameBase, efHistoryPath, h.dirs.Tmp, h.CompressorCfg, log.LvlTrace, h.logger)
if err != nil {
Expand All @@ -543,7 +543,7 @@ func (h *History) collate(ctx context.Context, step kv.Step, txFrom, txTo uint64
if h.noFsync {
_efComp.DisableFsync()
}
invIndexWriter := h.InvertedIndex.dataWriter(_efComp, true) // coll+build must be fast - no Compression
invIndexWriter := h.InvertedIndex.dataWriter(_efComp, true) // `Collate+Build` must be fast -> no Compression. Slowness here means growth of `chaindata`

keysCursor, err := roTx.CursorDupSort(h.KeysTable)
if err != nil {
Expand Down Expand Up @@ -860,15 +860,18 @@ func (h *History) dataReader(f *seg.Decompressor) *seg.Reader {
}
return seg.NewReader(f.MakeGetter(), h.Compression)
}
func (h *History) dataWriter(f *seg.Compressor) *seg.PagedWriter {
func (h *History) dataWriter(f *seg.Compressor, forceNoCompress bool) *seg.PagedWriter {
if !strings.Contains(f.FileName(), ".v") {
panic("assert: miss-use " + f.FileName())
}
if forceNoCompress {
return seg.NewPagedWriter(seg.NewWriter(f, seg.CompressNone), false, h.dirs.Tmp)
}
return seg.NewPagedWriter(seg.NewWriter(f, h.Compression), f.GetValuesOnCompressedPage() > 0, h.dirs.Tmp)
}
func (ht *HistoryRoTx) dataReader(f *seg.Decompressor) *seg.Reader { return ht.h.dataReader(f) }
func (ht *HistoryRoTx) datarWriter(f *seg.Compressor) *seg.PagedWriter {
return ht.h.dataWriter(f)
return ht.h.dataWriter(f, false)
}

func (h *History) isEmpty(tx kv.Tx) (bool, error) {
Expand Down
Loading