Replace TODO contexts with cancellable contexts in Heimdall version monitor tests #18762
+8
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taratorio
reviewed
Jan 23, 2026
| ) | ||
|
|
||
| func TestVersioMonitorHeimdallV2(t *testing.T) { | ||
| ctx, cancel := context.WithCancel(context.Background()) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: Heimdall version monitor tests were using context.TODO(), risking leaked goroutines.
Change: Switch tests to context.WithCancel and attach cancellation via t.Cleanup, passing the derived context into NewVersionMonitor.
Outcome: Tests clean up spawned goroutines deterministically; no behavior change to assertions.