-
Notifications
You must be signed in to change notification settings - Fork 795
Support for MariaDB database #548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Thanks @HugoWenTD. Please make sure to add a test case to the CI as well. |
Are you planning to finish this @HugoWenTD ? |
Yes Erik, I'll work on it this week. |
Ok, nice! |
547c78b
to
e59fc18
Compare
if batch: | ||
self._cur.executemany(self._sql_insert, batch) | ||
|
||
insert_time = time.time() - start_time |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps it would make sense to time just the "executemany" calls, not the python overhead of creating the batch?
If one is to compare these numbers to other DBs, it should time the operation the same. Is it with python overhead, or without in other DB's cases?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't really benchmark insertions & building the index, so I don't think it's material!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, it's just a print, but I'll see if can change it.
This is failing in CI for some reason, any idea why? https://github.com/erikbern/ann-benchmarks/actions/runs/14016901547/job/39890033550?pr=548 |
Weird. Looks it's failing with
|
I suspect it's related to the ThreadPool and mariadb cursor.
|
MariaDB supports Vector now. Add new module for benchmark against MariaDB 11.8 database server.
e59fc18
to
0291a06
Compare
Updated the batch_query. It should work now. |
MariaDB supports Vector now. https://mariadb.com/kb/en/vector-overview/
Add new module for benchmark against MariaDB 11.8 database server.