Initialize dominant_ac also for ac_wrong_modifier #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The check failed but it seems like an upstream issue and not something to do with my commit. |
added 5 commits
September 30, 2023 12:02
…last_seconds can be deleted by delete_show_before_first_commercial/delete_show_after_first_commercial
According to the documentation, setting delay_logo_search=1 delays it for added_recording amount of minutes. This did not work as expected.
bsperduto
added a commit
to bsperduto/Comskip
that referenced
this pull request
Dec 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't use cut_on_ac_change but I still use ac_wrong_modifier because it provides a pretty accurate weight.
Before, dominant_ac was only initialized when cut_on_ac_change was enabled. If it didn't it was incorrectly reported as 0:
Block 0 audio_channels (6) is different from dominant audio_channels (0). Block 0 score: Before - 0.50 After - 2.50(I hope it's clear what I mean)
My patch seems to work but I don't know the codebase well so there might be a better way to do this.