ssl: Correct gen_statem behaviour modules own alert handling #10284
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CT Test Results 2 files 66 suites 26m 55s ⏱️ Results for commit f55b778. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts
// Erlang/OTP Github Action Bot |
IngelaAndin
force-pushed
the
ingela/ssl/incorrect-throw/OTP-19813
branch
2 times, most recently
from
62e15e7 to
dfd770d
Compare
u3s
previously approved these changes
Oct 20, 2025
Own alerts shall be handled by the function ssl_gen_statem:handle_own_alert and not thrown as a local return in the behaviour modules. Alerts are only thrown from helper modules and caught by the main state machine behaviour module that will then call ssl_gen_statem:handle_own_alert.
IngelaAndin
force-pushed
the
ingela/ssl/incorrect-throw/OTP-19813
branch
from
dfd770d to
f55b778
Compare
u3s
approved these changes
Oct 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Own alerts shall be handled by the function
ssl_gen_statem:handle_own_alert and not thrown as a local return in the behaviour modules. Alerts are only thrown from helper modules and caught by the main state machine behaviour module that will then call ssl_gen_statem:handle_own_alert.