wxWidgets: Fixed the types of pixel values. #10303
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CT Test ResultsTests are running... https://github.com/erlang/otp/actions/runs/18640769744 Results for commit 25d6bb3 To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts
// Erlang/OTP Github Action Bot |
The GetRed, GetBlue, GetGreen in wxWidgets return `unsigned char`, But the code in wxe_wrapper_4.cpp is using `char` to receive the result and sign extending it into a int. As a result, a pixel whose red is `250`(`16#FA`) will be returned as `4294967290`(`16#FFFFFFFA`) by `wxImage:getRed/3`. This commit fixed this problem.
wallacegibbon
force-pushed
the
wx/wxImage-getRed-fix
branch
from
25d6bb3 to
49e92ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GetRed, GetBlue, GetGreen in wxWidgets return
unsigned char, But the code in wxe_wrapper_4 is usingcharto receive the result and sign extending it into a int.As a result, a pixel whose red is
250(16#FA) will be returned as4294967290(16#FFFFFFFA) bywxImage:getRed/3.This commit fixed this problem.