Skip to content
This repository has been archived by the owner on Nov 10, 2022. It is now read-only.

Fix: Add missing rules #479

Merged
merged 2 commits into from
May 28, 2018
Merged

Fix: Add missing rules #479

merged 2 commits into from
May 28, 2018

Conversation

platinumazure
Copy link
Member

This will fix 404 responses for links that point to max-classes-per-file and prefer-object-spread rules.

Root cause is eslint/eslint-release#22. Hopefully we can fix that before next release!

This fixes a broken link in docs/rules index. Root cause is eslint/eslint-release#22
This fixes a broken link in docs/rules index. Root cause is eslint/eslint-release#22
@eslint-deprecated eslint-deprecated bot added the triage An ESLint team member will look at this issue soon label May 28, 2018
@platinumazure platinumazure added bug The site is working incorrectly accepted There is consensus among the team that this change meets the criteria for inclusion and removed triage An ESLint team member will look at this issue soon labels May 28, 2018
Copy link

@hulkish hulkish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@not-an-aardvark
Copy link
Member

Since the files are being added manually, should we include a note at the top of the files that the rules are only available on an alpha release? It seems like someone could be surprised if they do npm install eslint@latest and some of the listed rules aren't present (although they could also check the bottom of the page to see when the rule was added, if necessary).

@platinumazure
Copy link
Member Author

@not-an-aardvark Agreed, but I would prefer to solve that problem separately/long term. This is just to fix broken links people are already reporting.

I created an issue on ESLint to discuss one possible approach: eslint/eslint#10412

@platinumazure platinumazure merged commit 566c1fb into master May 28, 2018
@platinumazure platinumazure deleted the copy-missing-rules branch May 29, 2018 14:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion bug The site is working incorrectly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants