feat: add fallback to npm registry API in fetchPeerDependencies #155
+127
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aladdin-add
reviewed
Mar 9, 2025
|
I am not exactly sure who to ask for a review here, maybe @mdjermanovic? |
aladdin-add
approved these changes
Mar 30, 2025
snitin315
reviewed
Mar 31, 2025
| @@ -79,8 +96,31 @@ function fetchPeerDependencies(packageName) { | |||
|
|
|||
| if (error && error.code === "ENOENT") { | |||
|
|
|||
| // TODO: should throw an error instead of returning null | |||
| return null; | |||
| // Fallback to using the npm registry API directly when npm is not available. | |||
There was a problem hiding this comment.
I think we should first check if npm is available via npm --version command and if it's available use npm show --json otherwise use fetch API. As per the current implementation, it will only use fetch if the error code is ENOENT.
There was a problem hiding this comment.
Since npm --version throws ENOENT when npm is missing, I don't see the need for an additional check. Could you clarify more?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enhances the
fetchPeerDependenciesfunction by adding a fallback mechanism. Ifnpmis unavailable, the function will now query the npm registry API directly to fetch peer dependencies.Closes #84