Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support updates to previous major versions #62

Merged
merged 5 commits into from
Sep 11, 2024

Conversation

mdjermanovic
Copy link
Member

Refs eslint/eslint#18691

Adds support for releasing new versions of previous major lines.

  • Code that calculates changelog will use the latest version tag of those that point to the history of the current branch only. That should ensure that the changelog and the version to be released are correctly calculated.
  • generateRelease() will have an optional parameter packageTag. When releasing, for example, v8.57.1 (the current latest version is v9.9.1), eslint's Makefile.js will pass "maintenance". This tag will be used as --tag for npm publish. This tag will also be used to determine whether GitHub should mark the GitHub release as Latest.

Marked as a draft to do some testing first.

@sam3k
Copy link

sam3k commented Sep 8, 2024

Per our formal EOL, we should aim to do this release by 2024-10-05 for v8.x.

In the 09-05-2024 tsc-meeting, we agreed to the following action items:

  • @nzakas is going to do a blog post next week announcing this release and mention the formal version support policy that we have posted.
  • HeroDevs will coordinate a blog post on their end as well.
  • @mdjermanovic will port the PR for Makefile.js in eslint/eslint to v8.x-dev and do an early release as soon as we feel confident it's ready for release

@mdjermanovic
Copy link
Member Author

This is ready for review. It's meant to work with eslint/eslint#18870 and eslint/eslint#18871.

Although these changes should be backwards compatible, it might be safer to release this after we determine that there's no need for a follow-up release for eslint v9.10.0 (i.e., when we close eslint/eslint#18819).

Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM. Could you add some docs to the README about how a prerelease works vs a regular release?

@mdjermanovic
Copy link
Member Author

I've updated README and added API section for this package. Docs on how we're specifically releasing ESLint using this package are added in eslint/eslint#18871.

.github/workflows/ci.yml Outdated Show resolved Hide resolved
Co-authored-by: Francesco Trotta <[email protected]>
Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Would like @fasttime to verify his feedback before merging.

Copy link
Member

@fasttime fasttime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@fasttime fasttime merged commit 2e6f2e6 into main Sep 11, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

4 participants