-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support updates to previous major versions #62
Conversation
Per our formal EOL, we should aim to do this release by 2024-10-05 for In the 09-05-2024 tsc-meeting, we agreed to the following action items:
|
This is ready for review. It's meant to work with eslint/eslint#18870 and eslint/eslint#18871. Although these changes should be backwards compatible, it might be safer to release this after we determine that there's no need for a follow-up release for eslint v9.10.0 (i.e., when we close eslint/eslint#18819). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM. Could you add some docs to the README about how a prerelease works vs a regular release?
I've updated README and added API section for this package. Docs on how we're specifically releasing ESLint using this package are added in eslint/eslint#18871. |
Co-authored-by: Francesco Trotta <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Would like @fasttime to verify his feedback before merging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Refs eslint/eslint#18691
Adds support for releasing new versions of previous major lines.
generateRelease()
will have an optional parameterpackageTag
. When releasing, for example, v8.57.1 (the current latest version is v9.9.1), eslint'sMakefile.js
will pass"maintenance"
. This tag will be used as--tag
fornpm publish
. This tag will also be used to determine whether GitHub should mark the GitHub release as Latest.Marked as a draft to do some testing first.