feat: show current prerelease version #502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for fr-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for new-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for es-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for zh-hans-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for ja-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for hi-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
mdjermanovic
commented
Dec 25, 2023
| @@ -40,10 +40,12 @@ const fetchWeeklyNpmDownloads = util.promisify(downloadStats.get.lastWeek); | |||
| async function fetchStatsFromGitHubAPI() { | |||
| const { repository } = await graphql(`query { | |||
| repository(owner:"eslint", name:"eslint") { | |||
| latestRelease { | |||
| publishedAt | |||
| isPrerelease | |||
There was a problem hiding this comment.
This wasn't working well, because latestRelease is never a prerelease.
✅ Deploy Preview for de-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for pt-br-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request?
Updates eslint.org homepage to show different versions when the current version is a prerelease:
Latest Version
Latest Prerelease Version
Upcoming Version
instead of (when the current version is not a prerelease):
Latest Version
Upcoming Version
Development
What changes did you make? (Give an overview)
tools/fetch-stats.jsto correctly fetch and calculate the current version and the latest version.Related Issues
eslint/eslint#17893 (comment)
Is there anything you'd like reviewers to focus on?
We'll need translations for "Latest Prerelease Version".