-
-
Notifications
You must be signed in to change notification settings - Fork 71
docs: multithread linting in v9.34.0 #750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for new-eslint ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for es-eslint ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for ja-eslint ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for hi-eslint ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for fr-eslint ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for zh-hans-eslint ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for pt-br-eslint ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for de-eslint ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like a good start. I left some notes on how to clean up the telling of this story.
Also, let's be sure to mention that concurrency=auto may not be the best setting for everyone and that people should try different settings to find the one that yields the best result. Maybe mention that it seems half of the number of physical cores seems to be the sweet spot for most folks, but there's no way to tell the number of physical cores from within Node.js.
Thanks for the suggestions. I updated the intro paragraph and moved the History and Challenges sections up to the top. I also added a few more points to the Challenges section and broke it up into subsections. The last paragraph from that section felt like a better fit for the Way Forward section, so I moved it there, then I moved the whole Way Forward part to the end. I also reworded the How It Works section and put it before the CLI usage and Node.js API usage sections. |
Added a new section to explain the limitations of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking really good, I just left a few places where it would be helpful to add links and details.
|
||
Turning that long-standing idea into a practical, user-friendly feature was far from trivial. The first step was to gather the many threads of past conversations — most notably the proposals and debates in [issue #3565](https://github.com/eslint/eslint/issues/3565) — and weave them into a coherent design that could work equally well from the CLI and the Node.js API. The goal was to introduce multithreading with as little disruption as possible for existing consumers. | ||
* Benchmark lint times before and after enabling concurrency to measure the impact. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to include details on using Hyperfine or other tools?
What about tips on where to start? Half the number of physical cores?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've elaborated the "Further Tips" section to mention these points. Please, have a look.
Co-authored-by: Nicholas C. Zakas <[email protected]>
Co-authored-by: Nicholas C. Zakas <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a blog post announcing the introduction of multithread linting in ESLint v9.34.0, documenting this significant performance enhancement feature.
- Creates comprehensive blog post explaining multithread linting feature and its history
- Documents CLI and Node.js API usage with examples and best practices
- Registers the new blog post in the blog dates configuration
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
File | Description |
---|---|
src/content/blog/2025-08-22-multithread-linting.md | Complete blog post documenting multithread linting feature, including history, technical challenges, usage examples, and performance tips |
src/_data/blog-dates.json | Adds timestamp entry for the new blog post |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <[email protected]>
I'm planning to merge this post as a draft and publish it along with the ESLint v9.34.0 announcement. |
Prerequisites checklist
What is the purpose of this pull request?
Added a blog post announcing multithread linting in ESLint v9.34.0
What changes did you make? (Give an overview)
Related Issues
eslint/eslint#19794
Is there anything you'd like reviewers to focus on?